Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS color variables, less bold font weight and more #13567

Merged
merged 4 commits into from
Nov 15, 2020
Merged

CSS color variables, less bold font weight and more #13567

merged 4 commits into from
Nov 15, 2020

Conversation

silverwind
Copy link
Member

  • Define color variables for fully saturated colors and apply them where it made sense
  • Add background color helper classes
  • Globally reduce bold font weight from 700 to 500
  • Remove border from timeline icons
  • Remove text colors from final box in Pull Requests
  • Unify dropzone styling
  • Various border style consolidations

Screen Shot 2020-11-14 at 19 29 24

image

Screen Shot 2020-11-14 at 19 40 59

image

@silverwind silverwind changed the title CSS color variables, less bold font weight CSS color variables, less bold font weight and more Nov 14, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 15, 2020
@lafriks lafriks added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 15, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 15, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 15, 2020
@zeripath
Copy link
Contributor

I think this may have actually broken a test...

gitea/integrations/pull_merge_test.go

Line 197 in 50cbb20

text := strings.TrimSpace(htmlDoc.doc.Find(".attached.merge-section.no-header > .text.grey").Last().Text())

@silverwind
Copy link
Member Author

Found two places that were selecting on the removed classes, fix attempt pushed.

@silverwind
CSS color variables, less bold font weight
1b3219a 
- Define color variables for fully saturated colors and apply them where
  it made sense
- Add background color helper classes
- Globally reduce bold font weight from 700 to 500
- Remove border from timeline icons
- Unify dropzone styling
- Various border style consolidations
@silverwind
attempt to fix test
5b7aae8
@silverwind
another attempt at tests
8bf9939
@silverwind
fix contains
3d25b37
@silverwind
Copy link
Member Author

Passing now.

@techknowlogick techknowlogick merged commit 0de5460 into go-gitea:master Nov 15, 2020
@silverwind silverwind deleted the csstweaks9 branch November 15, 2020 21:01
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@silverwind @zeripath @lafriks @mrsdizzie @techknowlogick @GiteaBot