Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS navbar and color tweaks #13609

Merged
merged 6 commits into from
Nov 26, 2020
Merged

CSS navbar and color tweaks #13609

merged 6 commits into from
Nov 26, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 17, 2020 •
edited

  • Many fixes to .new-menu
  • Fix admin bar overlapping menu bar
  • Fixes file edit comment box
  • Fix double border on review box
  • Fix review timeline icons

Screen Shot 2020-11-17 at 20 53 34

Screen Shot 2020-11-17 at 21 02 32

Screen Shot 2020-11-26 at 00 08 12

Screen Shot 2020-11-26 at 00 08 05

Screen Shot 2020-11-26 at 00 04 55

Screen Shot 2020-11-26 at 00 04 48

Screen Shot 2020-11-25 at 23 55 26

Screen Shot 2020-11-26 at 00 04 28

@techknowlogick techknowlogick added this to the 1.14.0 milestone Nov 17, 2020
@techknowlogick techknowlogick added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 17, 2020
@silverwind
Copy link
Member Author

Working on some more fixes regarding the new-menu navbar.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2020
@silverwind silverwind marked this pull request as draft November 25, 2020 21:21
@silverwind
CSS and color tweaks
1399770 
- Unify navbar-style menus
- Fix admin bar overlapping menu bar
- Fixes file edit comment box
- Fix double border on review box
- Fix review timeline icons
@silverwind
Many fixes to new-menu and navbar layout enhancements
b85a6af
@silverwind
Copy link
Member Author

silverwind commented Nov 25, 2020 •
edited

Many fixes done to .new-menu (the top menu seen on admin or user settings). It should now look correct in both themes, never overflow outside the screen, be centered on big screens, be scrollable on medium size screens and also looks ok on mobile layout. OP screenshots updated.

@silverwind silverwind marked this pull request as ready for review November 25, 2020 23:08
@silverwind silverwind changed the title CSS and color tweaks CSS navbar and color tweaks Nov 25, 2020
@silverwind
Copy link
Member Author

This is ready for review.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 26, 2020
@zeripath
Copy link
Contributor

So I think there's an issue with the commit graph page but I don't think this has been caused by this PR.

Screenshot from 2020-11-26 19-01-17

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2020
@zeripath zeripath merged commit b2de034 into go-gitea:master Nov 26, 2020
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

So I think there's an issue with the commit graph page but I don't think this has been caused by this PR.

Screenshot from 2020-11-26 19-01-17

this is indeed older, been meaning to report if for a while.

great changes btw @silverwind

@silverwind silverwind deleted the csstweaks10 branch November 26, 2020 20:48
@silverwind
Copy link
Member Author

@zeripath can you link such an issue on try.gitea.io?

@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@silverwind @zeripath @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf @mrsdizzie @techknowlogick @GiteaBot