Direct avatar rendering

[silverwind]

This adds new template helpers for avatar rendering which output image elements with direct links to avatars which makes them cacheable by the browsers.

This should be a major performance improvment for pages with many avatars.

[silverwind]

Besides removal of dead code which I still plan to do, this should now be fully functional.

[silverwind]

Gravatar avatars are not yet tested. Not sure yet if the changes from #10540 need further adjustments, the avatar code is highly convoluted unfortunately.

[silverwind]

Gravatar is working as well. Initially the images were a bit blurry on my high-dpi screen and I fixed that by increasing the requested size by two times.

[silverwind]

Org avatars are not working yet, they still emit those redirect URLs, not sure yet where to fix them.

[6543]

make fmt missing?

[silverwind]

This is ready for review now. Turns out org avatars were already working and caching, I was just confused by their different URL scheme (they use /avatars/num instead of storage paths).

I don't think there is anything left to clean up from the old avatar code, bits and pieces are still in use in some places.

[silverwind]

@6543 hmm I thought I fixed that earlier, will recheck.

[silverwind]

I think you have to remove models dependency on base

Actually I got around by moving everything into models, thankfully

This is ready again, federated avatars are uncached and working just like before. Gravatar and self-hosted avatars are of course caching.

[lunny]

@silverwind ha, I made a mistake.

[silverwind]

Planning to do one more small refactor later today because there is some duplication still left between base and models.

[6543]

@silverwind should we wait or start a follow up pull?

[silverwind]

i'll do it in the next few hours, it should be rather trivial, please wait.

[silverwind]

Dedupe done, ready now.

[6543]

realy nice refactor!

[mrsdizzie]

awesome ! 🖼