Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing stylesheets on installation page #13736

Merged
merged 2 commits into from Nov 28, 2020
Merged

Fix missing stylesheets on installation page #13736

merged 2 commits into from Nov 28, 2020

Conversation

shilch
Copy link
Contributor

@shilch shilch commented Nov 28, 2020

When running gitea for the first time, the stylesheets for the
installation page are broken since the middleware that statically serves
stylesheets does not get executed by chi. This is because if no handlers
are registered in chi, it will drop all middleware.

This commit introduces a "dummy" handler to deal with that quirk.

Closes #13725

Thanks: Lunny Xiao xiaolunwen@gmail.com for finding the quirk

When running gitea for the first time, the stylesheets for the
installation page are broken since the middleware that statically serves
stylesheets does not get executed by chi. This is because if no handlers
are registered in chi, it will drop all middleware.

This commit introduces a "dummy" handler to deal with that quirk.

Closes #13725

Thanks: Lunny Xiao <xiaolunwen@gmail.com> for finding the quirk
@lunny lunny added the type/bug label Nov 28, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 28, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2020
@codecov-io
Copy link

Codecov Report

Merging #13736 (6ba56ce) into master (1e5247d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13736      +/-   ##
==========================================
- Coverage   42.21%   42.19%   -0.03%     
==========================================
  Files         697      697              
  Lines       76845    76848       +3     
==========================================
- Hits        32439    32423      -16     
- Misses      39054    39072      +18     
- Partials     5352     5353       +1     
Impacted Files Coverage Δ
routers/routes/chi.go 35.18% <0.00%> (-0.67%) ⬇️
services/pull/check.go 48.90% <0.00%> (-3.65%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
modules/process/manager.go 72.50% <0.00%> (-2.50%) ⬇️
services/pull/patch.go 53.97% <0.00%> (-1.71%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
models/error.go 36.25% <0.00%> (-0.50%) ⬇️
modules/indexer/stats/db.go 52.17% <0.00%> (ø)
modules/git/repo.go 45.68% <0.00%> (+0.50%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e5247d...6ba56ce. Read the comment docs.

@lafriks lafriks merged commit 8c996c6 into go-gitea:master Nov 28, 2020
@shilch shilch deleted the bugfix/installation-stylesheets branch November 28, 2020 17:53
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitea/gitea:latest Docker image redirects everything with 302 to /
5 participants