Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve migrate page and add card CSS #13751

Merged
merged 2 commits into from
Dec 5, 2020
Merged

Improve migrate page and add card CSS #13751

merged 2 commits into from
Dec 5, 2020

Conversation

silverwind
Copy link
Member

  • Use original gitea logo on migrate page
  • Add card styles and map colors to css vars
  • Tweak migrate page, adding hover effect to cards

Screen Shot 2020-11-29 at 21 51 42

Screen Shot 2020-11-29 at 21 51 33

@6543
Copy link
Member

6543 commented Nov 29, 2020

@silverwind I think the wihte in the middle of gitea logo should be transparent, that's why I mainly did not use the original logo.
It just looks better on dark themes ... - any idear how to get same effect with original svg file?

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 29, 2020
@6543 6543 added the topic/ui Change the appearance of the Gitea UI label Nov 29, 2020
@silverwind
Copy link
Member Author

silverwind commented Nov 29, 2020 •
edited
Loading

Actually, the non-white center is what got me to replacing the logo. I think white parts of logos should stay white in dark themes and it's also consistent with the page logo/favicon.

@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 29, 2020
@6543
Copy link
Member

6543 commented Nov 29, 2020 •
edited
Loading

I'm realy not a fain of white-center ... I wont block the refactor - but in my opinion, would not change the logo

EDIT: write if you are done with refactoring this area :)

@6543 6543 added the pr/wip This PR is not ready for review label Nov 29, 2020
@silverwind
Copy link
Member Author

Happy with refactors already :)

@6543 6543 removed the pr/wip This PR is not ready for review label Nov 29, 2020
@lunny
Copy link
Member

lunny commented Nov 30, 2020

Actually, the non-white center is what got me to replacing the logo. I think white parts of logos should stay white in dark themes and it's also consistent with the page logo/favicon.

It's not consistent with other logos, both git and github has a transparent but gitea log doesn't.

@techknowlogick
Copy link
Member

It's not consistent with other logos, both git and github has a transparent but gitea log doesn't.

It makes our use of the logo consistent. Our logo in the upper left has the teabag filled in.

@silverwind
Copy link
Member Author

I guess after a certain degree of "internal complexitity" of a logo, it's warrented to fill that part white as it's not meant to be seen as transparent. Maybe it's just a personal preference of some that those parts are white but I've been getting used to it.

mrsdizzie
mrsdizzie approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@mrsdizzie mrsdizzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me -- the white is a teabag string and card which are actually white and supposed to be on the outside of the cup. Other logos are not really based so directly off of real world objects.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 30, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Nov 30, 2020
@silverwind silverwind mentioned this pull request Nov 30, 2020
Merged
@silverwind
Copy link
Member Author

Rebased. @6543 maybe you want to reconsider?

@6543
Copy link
Member

6543 commented Dec 2, 2020 •
edited
Loading

yes LGTM for the JS & CSS

but I'm still unhappy with the logo

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 2, 2020
@6543
Copy link
Member

6543 commented Dec 4, 2020

@silverwind conflicts ocure :/

@silverwind
Improve migrate page and add card CSS
82fa3b6 
- Use original gitea logo on migrate page
- Add card styles and map colors to css vars
- Tweak migrate page, adding hover effect to cards
@silverwind
Copy link
Member Author

Rebased.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 4, 2020
@lunny lunny removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 5, 2020
@lafriks lafriks merged commit 61d6c19 into go-gitea:master Dec 5, 2020
@silverwind silverwind deleted the migratefixes branch December 5, 2020 12:16
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@silverwind @6543 @lunny @techknowlogick @lafriks @mrsdizzie @GiteaBot