Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Noto Color Emoji fallback #13838

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Remove Noto Color Emoji fallback #13838

merged 1 commit into from
Dec 4, 2020

Conversation

silverwind
Copy link
Member

It's causing browser errors logged in Firefox under certain circumstances, and I think we're better off recommending Linux users to install a proper emoji font into their system.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 4, 2020
@6543 6543 added pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Dec 4, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2020
@6543
Copy link
Member

6543 commented Dec 4, 2020

I marked it as "breaking" but alternative I think adding a hint into FAQ my emojis have no color / not displayed correctly would also do it ...

@6543
Copy link
Member

6543 commented Dec 4, 2020

@silverwind should we add a FAQ instead?

@silverwind
Copy link
Member Author

Yes, I'll add something in the docs.

@silverwind silverwind marked this pull request as draft December 4, 2020 07:23
@silverwind silverwind marked this pull request as ready for review December 4, 2020 13:49
@silverwind
Copy link
Member Author

FAQ entry added.

@silverwind
Remove Noto Color Emoji fallback
8123082 
It's causing browser errors logged in Firefox under certain
circumstances, and I think we're better off recommending Linux users to
install a proper emoji font into their system.
@6543 6543 removed the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Dec 4, 2020
@6543 6543 merged commit d8c2c6c into go-gitea:master Dec 4, 2020
@silverwind silverwind deleted the rmnoto branch December 4, 2020 15:05
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @6543 @mrsdizzie @GiteaBot