Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo avatar fixes #13891

Merged
merged 3 commits into from
Dec 8, 2020
Merged

Repo avatar fixes #13891

merged 3 commits into from
Dec 8, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 7, 2020 •
edited

  • Split up avatar rendering helpers for performance
  • Fix showing repo SVG icon when no avatar is set
  • Make repo SVG and avatar same size at 32px
  • Fix fork line by adding vertical flexbox on repo title

Screen Shot 2020-12-08 at 01 14 15

Screen Shot 2020-12-08 at 01 14 23

Screen Shot 2020-12-07 at 21 42 04

Screen Shot 2020-12-07 at 21 41 53

silverwind
silverwind commented Dec 7, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 7, 2020
@silverwind silverwind added type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality. topic/ui Change the appearance of the Gitea UI labels Dec 7, 2020
@silverwind silverwind added this to the 1.14.0 milestone Dec 7, 2020
@silverwind silverwind force-pushed the repoava branch 3 times, most recently from 16da861 to 85d57ba Compare December 8, 2020 00:09
@silverwind
Repo avatar fixes
3461337 
- Split up avatar rendering helpers for performance
- Fix showing repo SVG icon when no avatar is set
- Make repo SVG and avatar same size at 32px
- Fix fork line by adding vertical flexbox on repo title
@6543

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 8, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 8, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit e7938c9 into go-gitea:master Dec 8, 2020
@silverwind silverwind deleted the repoava branch December 8, 2020 22:23
@CirnoT CirnoT mentioned this pull request Dec 12, 2020
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @6543 @techknowlogick @lunny @GiteaBot