Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 20 characters for "View [organization]" button #13906

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

jpraet
Copy link
Member

@jpraet jpraet commented Dec 8, 2020

In the "View [organization]" button on the dashboard, the organization name is currently shortened to 10 chars.
This is a bit too limited. In all other places in the code where the name is shortened this was already set to 20 instead of 10.

image

In the "View [organization]" button on the dashboard, the organization name is currenly shortened to 10 chars.
This is a bit too limited. In all other places in the code the name is also shortened to 20 instead of 10.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 8, 2020
@lafriks lafriks added topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 8, 2020
@lafriks lafriks added this to the 1.14.0 milestone Dec 8, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 8, 2020
@codecov-io
Copy link

Codecov Report

Merging #13906 (5bc5156) into master (6a37036) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13906      +/-   ##
==========================================
+ Coverage   42.10%   42.13%   +0.02%     
==========================================
  Files         709      709              
  Lines       77187    77187              
==========================================
+ Hits        32502    32524      +22     
+ Misses      39333    39311      -22     
  Partials     5352     5352              
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/queue/unique_queue_channel.go 58.06% <0.00%> (-6.46%) ⬇️
models/error.go 38.98% <0.00%> (+0.48%) ⬆️
modules/git/repo.go 46.23% <0.00%> (+0.50%) ⬆️
modules/log/event.go 60.84% <0.00%> (+1.88%) ⬆️
models/issue_comment.go 45.46% <0.00%> (+1.96%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
services/pull/check.go 51.82% <0.00%> (+2.91%) ⬆️
modules/git/utils.go 77.04% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a37036...5bc5156. Read the comment docs.

@techknowlogick techknowlogick merged commit 1a372e5 into go-gitea:master Dec 8, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
@jpraet jpraet deleted the org-name-20 branch January 22, 2021 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants