Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JS globals related to timetracking and due date #13921

Merged
merged 2 commits into from Dec 10, 2020
Merged

Remove JS globals related to timetracking and due date #13921

merged 2 commits into from Dec 10, 2020

Conversation

silverwind
Copy link
Member

Refactor to avoid these globals. Should work exactly as before.

@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 9, 2020
@silverwind silverwind added this to the 1.14.0 milestone Dec 9, 2020
@silverwind
Remove JS globals related to timetracking and due date
120c8e7 
Refactor to avoid these globals. Should work exactly as before.
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 9, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 10, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2020
@6543
Copy link
Member

6543 commented Dec 10, 2020

🚀

@6543 6543 merged commit 1cb1fb8 into go-gitea:master Dec 10, 2020
@silverwind silverwind deleted the less-globals branch December 10, 2020 16:25
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @6543 @lunny @GiteaBot