Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix avatar template error on repo collaborator page #13924

Merged
merged 2 commits into from Dec 10, 2020
Merged

Fix avatar template error on repo collaborator page #13924

merged 2 commits into from Dec 10, 2020

Conversation

silverwind
Copy link
Member

Fixes error template: repo/settings/collaboration:16:16: executing "repo/settings/collaboration" at <.>: wrong type for value; expected *models.User; got *models.Collaborator seen on repo collaborator page.

@silverwind
Fix avatar template error on repo collaborator page
0bc3cd2 
Fixes error `template: repo/settings/collaboration:16:16: executing
"repo/settings/collaboration" at <.>: wrong type for value; expected
*models.User; got *models.Collaborator` seen on repo collaborator page.
@silverwind silverwind added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 10, 2020
@silverwind silverwind added this to the 1.14.0 milestone Dec 10, 2020
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Copy link
Contributor

yes please! 🎉
just stumbled upon this on my instance, cheers that you already have a fix! @silverwind

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 10, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 10, 2020
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just applied the patch, works fine on my instance :)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 10, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit ccfa408 into go-gitea:master Dec 10, 2020
@silverwind silverwind deleted the collaborator branch December 10, 2020 07:21
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@silverwind @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf @techknowlogick @lunny @mrsdizzie @GiteaBot