Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HEAD to match defaultBranch in template generation #13948

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Update HEAD to match defaultBranch in template generation #13948

merged 2 commits into from
Dec 11, 2020

Conversation

zeripath
Copy link
Contributor

Fix #13912

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Ensure that HEAD is updated to match default branch in template gener…
43e37c5 
…ation

Fix go-gitea#13912

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.14.0 milestone Dec 11, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 11, 2020
@codecov-io
Copy link

codecov-io commented Dec 11, 2020 •
edited
Loading

Codecov Report

Merging #13948 (043a165) into master (f2f99a7) will increase coverage by 0.10%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13948      +/-   ##
==========================================
+ Coverage   42.14%   42.24%   +0.10%     
==========================================
  Files         710      710              
  Lines       77211    77218       +7     
==========================================
+ Hits        32537    32621      +84     
+ Misses      39325    39226      -99     
- Partials     5349     5371      +22
Impacted Files Coverage Δ
modules/repository/generate.go 0.00% <0.00%> (ø)
modules/repository/init.go 41.83% <100.00%> (+0.29%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/stats/queue.go 52.94% <0.00%> (-11.77%) ⬇️
modules/queue/unique_queue_channel.go 58.06% <0.00%> (-6.46%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
modules/git/repo.go 45.72% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 40.68% <0.00%> (ø)
models/error.go 39.31% <0.00%> (+0.32%) ⬆️
models/gpg_key.go 53.90% <0.00%> (+0.57%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2f99a7...043a165. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2020
@6543 6543 merged commit 8e0548e into go-gitea:master Dec 11, 2020
@zeripath zeripath deleted the fix-13912-set-HEAD-to-default-branch-during-generation branch December 11, 2020 22:17
@kb173
Copy link

kb173 commented Dec 11, 2020

Thanks very much for fixing this so quickly!

@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

HEAD is not set to alternative default brach when using a template
6 participants
@zeripath @codecov-io @kb173 @silverwind @6543 @GiteaBot