Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown task list improvements #13952

Merged
merged 4 commits into from
Dec 13, 2020
Merged

Markdown task list improvements #13952

merged 4 commits into from
Dec 13, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 11, 2020

  • Remove .ui class and wrappers to prevent fomantic from messing with it and making text selection possible on the task text.
  • Change rendered HTML to match GitHub.
  • Add custom styling for the checkboxes.

Screen Shot 2020-12-11 at 20 48 01

Screen Shot 2020-12-11 at 20 48 11

Note, indeterminate state in those screenshots is just to showcase the state, it can not be rendered as such but JS can set it.

cc: @j2L4e

- Remove `.ui` class and wrappers to prevent fomantic from messing with it.
- Change rendered HTML to match GitHub.
- Add custom styling for the checkboxes.
@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality and removed skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 11, 2020
@silverwind silverwind added this to the 1.14.0 milestone Dec 11, 2020
@silverwind silverwind removed the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 11, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 12, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2020
@lunny
Copy link
Member

lunny commented Dec 13, 2020

make L-G-T-M work.

@lunny lunny merged commit 41e8b83 into go-gitea:master Dec 13, 2020
@silverwind silverwind deleted the mdcheck branch December 14, 2020 09:16
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants