Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework heatmap permissions #14080

Merged
merged 10 commits into from Dec 22, 2020
Merged

rework heatmap permissions #14080

merged 10 commits into from Dec 22, 2020

Conversation

noerw
Copy link
Member

@noerw noerw commented Dec 20, 2020

  • heatmap now uses the same permission model as the activity feed:
    only include activities in repos, that the doer has access to.
    this might be somewhat slower.
  • also improves handling of user.KeepActivityPrivate (still show the heatmap to self & admins)

fixes #14066, fixes #14086

- now uses the same permission model as for the activity feed:
  only include activities in repos, that the doer has access to.
  this might be somewhat slower.
- also improves handling of user.KeepActivityPrivate (still shows
  the heatmap to self & admins)
@noerw noerw added the type/enhancement An improvement of existing functionality label Dec 20, 2020
@codecov-io
Copy link

Codecov Report

Merging #14080 (dc5c959) into master (e8a354f) will increase coverage by 0.02%.
The diff coverage is 78.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14080      +/-   ##
==========================================
+ Coverage   42.32%   42.35%   +0.02%     
==========================================
  Files         726      726              
  Lines       77689    77709      +20     
==========================================
+ Hits        32884    32913      +29     
+ Misses      39405    39401       -4     
+ Partials     5400     5395       -5     
Impacted Files Coverage Δ
models/action.go 52.90% <71.42%> (+2.90%) ⬆️
models/user_heatmap.go 78.78% <88.23%> (-1.99%) ⬇️
routers/api/v1/user/user.go 50.00% <100.00%> (ø)
routers/user/home.go 60.67% <100.00%> (ø)
routers/user/profile.go 48.00% <100.00%> (ø)
modules/queue/workerpool.go 58.77% <0.00%> (-2.05%) ⬇️
services/pull/pull.go 41.37% <0.00%> (ø)
routers/api/v1/repo/pull.go 25.45% <0.00%> (+0.60%) ⬆️
modules/git/batch_reader_nogogit.go 46.26% <0.00%> (+1.49%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a354f...dc5c959. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 21, 2020
@noerw noerw mentioned this pull request Dec 21, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 21, 2020
@6543 6543 added this to the 1.14.0 milestone Dec 21, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 21, 2020
@6543
Copy link
Member

6543 commented Dec 22, 2020

🚀

@6543 6543 merged commit f6bec85 into go-gitea:master Dec 22, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't see heatmap after hiding profile from public heatmap shouldn't display stats of private repositories
6 participants