Add UI to delete tracked times

[noerw]

Adds a button on time tracker issue comments to delete a tracked time again (in an append-only-log style).
This button is available only to the poster of the tracked time and site admins.

Caveat is, that this does not work for times created until now, as the comment has no reference to the time ID. (This could probably be resolved once via a migration that mactches comments & times with common fields, but thats far out of my comfort zone)

I'm not very familiar with gitea codebase yet, so better check things twice.
In particular I don't know if a migration is needed for the fields added to Comment..

fixes #2642

[6543]

this code will never be used ... - change it

[lafriks]

It should ask for confirmation in dialog if you really want to delete it

[noerw]

It should ask for confirmation in dialog if you really want to delete it

@lafriks done!

[codecov-io]

Codecov Report

Merging #14100 (18d62ef) into master (91e59a6) will increase coverage by 0.00%.
The diff coverage is 27.50%.

@@           Coverage Diff           @@
##           master   #14100   +/-   ##
=======================================
  Coverage   41.76%   41.77%           
=======================================
  Files         748      749    +1     
  Lines       80103    80143   +40     
=======================================
+ Hits        33458    33476   +18     
- Misses      41123    41147   +24     
+ Partials     5522     5520    -2     

Impacted Files	Coverage Δ
models/migrations/migrations.go	2.28% <ø> (ø)
models/migrations/v167.go	0.00% <0.00%> (ø)
routers/repo/issue_timetrack.go	0.00% <0.00%> (ø)
models/issue_comment.go	52.46% <71.42%> (+0.19%)	⬆️
models/issue_stopwatch.go	71.68% <100.00%> (+0.25%)	⬆️
models/issue_tracked_time.go	69.93% <100.00%> (+0.18%)	⬆️
routers/repo/issue.go	38.48% <100.00%> (+0.11%)	⬆️
routers/routes/macaron.go	93.27% <100.00%> (+<0.01%)	⬆️
modules/util/timer.go	42.85% <0.00%> (-42.86%)	⬇️
modules/queue/unique_queue_disk_channel.go	53.84% <0.00%> (-1.54%)	⬇️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9872b8d...18d62ef. Read the comment docs.

[silverwind]

The use of a rounded button seems a bit odd to me. Don't we already have rectangular buttons in use in the history somewhere? Would prefer a rectangular button with text and maybe a icon.

[delvh]

If I see correctly what this PR is doing, there is currently no support to revert time using the API, right?
Should an issue be opened for that as soon as this branch gets merged?

[lunny]

@lafriks Need your review again.

[6543]

@delvh just look at:

• https://try.gitea.io/api/swagger#/issue/issueResetTime
• https://try.gitea.io/api/swagger#/issue/issueDeleteTime

[delvh]

@6543 wait, it's already supported for the API but not for the web interface? Strange…

[lunny]

See #14100 (comment), otherwise LGTM.

stale

[6543]

@lunny done