Prevent clipping input text in Chrome + Segoe UI Font

[kdumontnu]

Closes #14162

Before

After

The overall element height stays the same.

There is an issue in Chrome + Windows where the line-height is cropped too short. It seems like at least partially an issue with how Chrome calculates the height, but this fix should be more stable for different user fonts.

Note: I changed only the clone panel css classes. The other input elements remain as they were, as they didn't have the same issue with cropping the text.

[silverwind]

Can't reproduce on macOS but I wonder what's causing the clipping in first place. Normally, such clipping is caused by overflow: hidden but it's not set and even if I set a lower line-height like .5em, it would never clip because padding essentially counter-acts it. I must be missing something.

[kdumontnu]

Can't reproduce on macOS

Perhaps if you use Segoe UI font (which is what I get with system-ui on Windows).

even if I set a lower line-height like .5em, it would never clip because padding essentially counter-acts it.

Hmm, appears your right. I assumed that since left/right padding clip text that the bottom padding would clip as well. However, when I set height: 28px the bottom padding doesn't clip the text. Only the low line-height clips the text (in Chrome).

I'll update the Chrome bug.

I'm okay if you want to close this and just wait for a fix to come in Chrome. I'll probably merge the change in my fork.

[zeripath]

@silverwind I've seen clipping like this too. - but it might have been on segoe ui too

[zeripath]

https://try.gitea.io/arandomer/merge-test

with noto sans

[zeripath]

this pr does fix that issue

[codecov-io]

Codecov Report

Merging #14179 (5fed2c3) into master (21adeaa) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14179      +/-   ##
==========================================
- Coverage   42.02%   42.00%   -0.03%     
==========================================
  Files         734      734              
  Lines       78780    78780              
==========================================
- Hits        33106    33088      -18     
- Misses      40239    40251      +12     
- Partials     5435     5441       +6     

Impacted Files	Coverage Δ
modules/indexer/stats/db.go	40.00% <0.00%> (-20.00%)	⬇️
modules/indexer/stats/queue.go	64.70% <0.00%> (-11.77%)	⬇️
modules/process/manager.go	72.50% <0.00%> (-2.50%)	⬇️
modules/git/repo_commit_nogogit.go	63.33% <0.00%> (-1.67%)	⬇️
models/gpg_key.go	53.33% <0.00%> (-0.58%)	⬇️
services/pull/pull.go	42.35% <0.00%> (-0.51%)	⬇️
models/error.go	38.49% <0.00%> (-0.49%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21adeaa...5fed2c3. Read the comment docs.

[lafriks]

Please update with base branch