Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kd/fix team avatar aspect ratio #14200

Merged
merged 4 commits into from
Jan 3, 2021

Conversation

kdumontnu
Copy link
Contributor

Fixes broken aspect ratio for avatars in org members list admin page.

Before:

image

After:

aspect ratio is preserved for avatar (with fixed width)
min-width is set to prevent single-character text lines
image

@kdumontnu kdumontnu force-pushed the kd/fix-team_avatar_aspect_ratio branch from 2a2013a to ecd8f42 Compare December 31, 2020 05:28
@codecov-io
Copy link

codecov-io commented Dec 31, 2020

Codecov Report

Merging #14200 (552f86d) into master (7576e37) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14200   +/-   ##
=======================================
  Coverage   41.96%   41.97%           
=======================================
  Files         735      735           
  Lines       78928    78928           
=======================================
+ Hits        33126    33130    +4     
+ Misses      40347    40344    -3     
+ Partials     5455     5454    -1     
Impacted Files Coverage Δ
services/pull/pull.go 42.78% <0.00%> (+0.49%) ⬆️
modules/log/event.go 59.90% <0.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7576e37...552f86d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 31, 2020
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Dec 31, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Dec 31, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 3, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 3, 2021
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 3, 2021
@6543
Copy link
Member

6543 commented Jan 3, 2021

@kdumontnu pleace "Update Branch"

@zeripath
Copy link
Contributor

zeripath commented Jan 3, 2021

please update the branch. In general it's better if you allow maintainers to push to the branch.

@techknowlogick
Copy link
Member

@zeripath this fork belongs to an org, so the standard maintainer checkbox isn’t an option :(

@kdumontnu
Copy link
Contributor Author

@zeripath @6543 @techknowlogick all set

@6543 6543 merged commit 4092c04 into go-gitea:master Jan 3, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
@kdumontnu kdumontnu deleted the kd/fix-team_avatar_aspect_ratio branch February 16, 2021 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants