Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of the race detector #1430

Closed
typeless opened this issue Apr 1, 2017 · 7 comments · Fixed by #1441
Closed

Make use of the race detector #1430

typeless opened this issue Apr 1, 2017 · 7 comments · Fixed by #1441
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Milestone

Comments

@typeless
Copy link
Contributor

typeless commented Apr 1, 2017

The race detector is helpful for discovering race conditions in concurrent programs. The easiest way I can think of is to add a new target or some kind of env. variable in the Makefile to enabe -race. We could also begin running try.gitea.io with the race detector enabled.

Edit:this is not just a proposal, but also a call for ideas about how we are going to do it.

@tboerger
Copy link
Member

tboerger commented Apr 1, 2017

An env variable which is enabled on the ci makes sense

@strk
Copy link
Member

strk commented Apr 1, 2017

How about GOFLAGS ?

@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Apr 1, 2017
@typeless
Copy link
Contributor Author

typeless commented Apr 4, 2017

@strk I don't understand how to apply GOFLAGS to the Makefile. Can you elaborate?

I submitted a PR for it.

@strk
Copy link
Member

strk commented Apr 4, 2017 via email

@lunny lunny added this to the 1.2.0 milestone Apr 4, 2017
@lunny lunny modified the milestones: 1.3.0, 1.2.0 May 26, 2017
@lunny lunny modified the milestones: 1.3.0, 1.4.0 Oct 25, 2017
@lafriks lafriks modified the milestones: 1.4.0, 1.5.0 Jan 14, 2018
@lunny lunny modified the milestones: 1.5.0, 1.6.0 May 11, 2018
@lafriks lafriks modified the milestones: 1.6.0, 1.7.0 Sep 16, 2018
@techknowlogick techknowlogick modified the milestones: 1.7.0, 1.8.0 Dec 19, 2018
@stale
Copy link

stale bot commented Feb 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 17, 2019
@techknowlogick techknowlogick modified the milestones: 1.8.0, 1.9.0 Feb 19, 2019
@stale stale bot removed the issue/stale label Feb 19, 2019
@stale
Copy link

stale bot commented Apr 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 20, 2019
@stale
Copy link

stale bot commented May 4, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed May 4, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label May 5, 2019
@lunny lunny reopened this May 5, 2019
@stale stale bot removed the issue/stale label May 5, 2019
@techknowlogick techknowlogick modified the milestones: 1.9.0, 1.10.0 Jun 25, 2019
@techknowlogick techknowlogick modified the milestones: 1.10.0, 1.11.0 Sep 3, 2019
@techknowlogick techknowlogick modified the milestones: 1.11.0, 1.x.x Dec 30, 2019
@lunny lunny modified the milestones: 1.x.x, 1.16.0 Sep 2, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants