Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to alpine 3.13 #14343

Merged
merged 4 commits into from
Jan 20, 2021
Merged

upgrade to alpine 3.13 #14343

merged 4 commits into from
Jan 20, 2021

Conversation

techknowlogick
Copy link
Member

as title

blocked by golang image upstream not yet being updated

@techknowlogick techknowlogick added this to the 1.14.0 milestone Jan 15, 2021
@techknowlogick techknowlogick added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 15, 2021
@tomaswarynyca
Copy link
Contributor

tomaswarynyca commented Jan 15, 2021 •
edited
Loading

The image does not exist in dockerhub. golang:1.15-alpine3.13
I just opened an issues to see if they can compile it
docker-library/golang#353

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 15, 2021
@techknowlogick
Copy link
Member Author

@tomaswarynyca it usually takes a few days for the upstream image to be built. that is what is meant by blocked in my comment above. thanks for opening issue.

@gary-kim
Copy link
Member

Image is built now

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 20, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 20, 2021
@6543 6543 merged commit b708968 into go-gitea:master Jan 20, 2021
@techknowlogick techknowlogick deleted the alpine-3.13 branch January 20, 2021 06:05
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@gary-kim gary-kim gary-kim approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@techknowlogick @tomaswarynyca @gary-kim @6543 @GiteaBot