Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove outdated notice in makefile #14720

Merged
merged 2 commits into from
Feb 18, 2021
Merged

remove outdated notice in makefile #14720

merged 2 commits into from
Feb 18, 2021

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Feb 18, 2021
jolheiser
jolheiser approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't recall when or why this was a thing. LGTM

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 18, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 18, 2021
@techknowlogick
Copy link
Member Author

@jolheiser it was when due to when we switched to go1.15 and there was a bug when cross-compiling on windows. I forgot to remove this note when it ended up being fixed.

@techknowlogick techknowlogick merged commit ce03464 into go-gitea:master Feb 18, 2021
@techknowlogick techknowlogick deleted the techknowlogick-patch-3 branch February 18, 2021 02:48
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@techknowlogick @6543 @jolheiser @GiteaBot