SVG Spacing restricted to direct descendants of items
#14761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
lafriks
approved these changes
Feb 21, 2021
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Feb 21, 2021
GiteaBot
added
lgtm/done
|
🚀 |
techknowlogick
added
the
skip-changelog
6543
pushed a commit
that referenced
this pull request
Feb 25, 2021
This PR fixes a few UI bugs I spontaneously encountered: - Fixes emojis in repo titles getting head-cut and tail-cut in dashboard feed due to introduction of 1.25 em emojis at 1 em line-height, by simply using the original 1 3/7 em value of `semantic.css` - Fixes regression (too long repo names should be capped to 70%) in #13828 due to flex children not respecting properties like `overflow: hidden;`, and removes a block of dead style code - Follow-up to #14761, removes extraneous code for top navbar and correct right margin for Font Awesome - Fixes color emphasis inversion in arc-green theme for top right buttons (edit, delete) on commit view boxes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14638 (comment)
Minor change to restrict svg spacing applied only to direct descendants of menu items. This prevents the styling from being applied to submenu items.
It's worth pointing out this issue was one of many that led me to write about my thoughts on styling in this project.
@CL-Jeremy Thanks for pointing this out.