Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/UI] Using the code editor is practically impossible on mobile #14776

Open
Reinitialized opened this issue Feb 22, 2021 · 12 comments
Open

[BUG/UI] Using the code editor is practically impossible on mobile #14776

Reinitialized opened this issue Feb 22, 2021 · 12 comments
Labels
topic/ui Change the appearance of the Gitea UI

Comments

@Reinitialized
Copy link

Reinitialized commented Feb 22, 2021

As a user and programmer using Gitea, it is impossible in practice to utilize the built in code editor for making quick changes on a file. Attempting to scroll through the editor results in a "right click" menu to pop up displaying keyboard shortcuts as if I'm using a mouse/keyboard, and deleting text does not seem to register at all.

IMO, Gitea is intended to be an extended toolset on top of git, making the UX of the git toolset easier to use. I think the current editor implementation is out of scope and feature bloat, and propose replacing such along the lines of:

  • textarea
  • shows line numbers on the left

Gitea should not be a replacement for an IDE. For reference sake, as this classifies as a separate issue nor have I tested such tools myself, Gitea should ensure it is able to cleanly integrate with existing tools such as GitPod or Theia, not implement a "half baked" alternative as currently existing. Editing files on Gitea should be for "quick fixes", such as typos or something along the line of only taking a minute or two to do.

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Feb 23, 2021
@Reinitialized Reinitialized changed the title [BUG/UX] Using the code editor is practically impossible on mobile [BUG/UI] Using the code editor is practically impossible on mobile Feb 23, 2021
@phtan
Copy link
Contributor

phtan commented Feb 24, 2021

I have had a similar problem with the menu that appears on "right click" (or "long press" on mobile (Android)).

When I want to paste some code/text into the text-editor (of Gitea) - while using a mobile phone - I do a long press. I expected an option of "paste" to appear. But I saw a menu that features keyboard shortcuts.

This situation obstructs me from pasting. This is ususual behaviour for software that runs on mobile phones, to put things mildly.

@phtan
Copy link
Contributor

phtan commented Feb 24, 2021

I wonder if changing the below-hyperlinked line of code gets rid of the offending "right-click menu"?

Specifically, changing "activate" to "nothing" 🤔

I have no development environment right now to test if the above change indeed succeeds. (I.e. no laptop nor desktop Personal Computer for now, just a mobile phone). I'm just going to make a suggestion here, in case someone else can implement this suggestion (and possibly make a Pull Request).

action : 'activate', // action on item selection (nothing, activate, select, combo, hide, function(){})

@Username404-59
Copy link

Username404-59 commented Feb 24, 2021

I can confirm this, the editor also seems to be a bit broken on mobile; typing characters works (with latency?) but removing them does not.

@Thewisem
Copy link

I second this. Its a pain to do anything in that text editor

@fairking

This comment was marked as off-topic.

@HackerDaGreat57
Copy link

@fairking first you have to add at least one file via command line Git only then you can start adding files via web.

@redthing1
Copy link

This editor is endlessly frustrating on mobile. I hope we can resolve it. Maybe even serving a different editor for a mobile device?

@silverwind
Copy link
Member

There were some recent improvements in Monaco related to Mobile. Try in latest gitea version.

@Forza-tng
Copy link

Hi. I came here too because editing files via mobile UI is mostly impossible. I don't think a lot needs to be adjusted to make it work and it would be of great benefit.

  • cant select text
  • cant paste
  • difficult to scroll - it moves back to top
  • cant see all text because keyboard covers.

I'm using Gitea 1.21.2 on Gentoo Linux

My workaround is to do ssh from my phone, make changes in nano and the git push... Needless to say this isn't very efficient.

Screen_Recording_20231217_195224_Opera.webm

@duchenpaul
Copy link

Yes, can we just have a toggle in the config file that disables this editor to make the code editor as a giant text box?

This code editor is stupid.

@delvh
Copy link
Member

delvh commented Jun 9, 2024

#30474 😁

@wxiaoguang
Copy link
Contributor

#30474 😁

30474 is for "markdown editor" (for issue/comment/wiki content editing)

This issue's problem is the "code editor": currently Monaco Editor on the "Edit File" page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

No branches or pull requests