show private heatmap on profile to self & admins #14881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
followup to go-gitea#14080, i thought i changed that back then..
rendering is wanted for freshly created users. rendering might be unwanted, if doer has no permission to view anyway
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
approved these changes
Mar 4, 2021
There was a problem hiding this comment.
works great 🚀
show's heatmap even when it's empty (which it should).
admin's view of a user with disabled public activity (essentially the user themselves sees the same):
non-empty user's view heatmap:
other users, of course, see only the message telling that the user has public activity disabled.
EDIT: added user's view with non-empty activity.
GiteaBot
added
the
lgtm/need 2
6543
added
the
skip-changelog
|
@noerw look's like test's fail related |
6543
approved these changes
Mar 4, 2021
GiteaBot
added
lgtm/need 1
6543
requested changes
Mar 4, 2021
This comment has been minimized.
This comment has been minimized.
zeripath
approved these changes
Mar 4, 2021
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #14080, i thought i changed that back then..
this could go with skip-changelog into 1.14, but is not critical i guess