Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading progressbar on Gitea #14

Closed
joubertredrat opened this issue Nov 2, 2016 · 16 comments
Closed

Loading progressbar on Gitea #14

joubertredrat opened this issue Nov 2, 2016 · 16 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@joubertredrat
Copy link
Contributor

joubertredrat commented Nov 2, 2016

Hi guys,

This is a small Feature suggestion for Gogs UX. On my projects, I use page loading progress bar and is simple to use, similar from Youtube, when page is loading, is possible to see loading progressbar on top page.

I use this plugin with theme Flash and worked very fine here.

What you think?

Reference: gogs/gogs#3693

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/38896725-loading-progressbar-on-gitea?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F47456670&utm_medium=issues&utm_source=github).
@metalmatze
Copy link
Contributor

Something like that would be really nice, but not a must have.
I'd say go for it! 😊

@jhasse
Copy link

jhasse commented Nov 3, 2016

I think such a thing should be inplemented by the browser, not by every website for itstelf.

@tboerger tboerger changed the title [Feature suggestion] Loading progressbar on Gogs Loading progressbar on Gogs Nov 3, 2016
@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
@tboerger tboerger added this to the 1.x.x milestone Nov 3, 2016
@metalmatze
Copy link
Contributor

But currently it isn't implemented by every browser. I don't see anything against this.

@jhasse
Copy link

jhasse commented Nov 3, 2016

  • Code complexity
  • Some browsers (e. g. Epiphany) already have a progress bar where this will look ugly
  • Increased load time
  • Some people might not visually like it (like myself)

@joubertredrat
Copy link
Contributor Author

  • Is easy, you add only 2 files and nothing else
<script src="/pace/pace.js"></script>
<link href="/pace/themes/pace-theme-barber-shop.css" rel="stylesheet" />
  • I didn't know that have browsers with progress bar
  • On my projects, don't have relevant increase load time
  • We can put this on vote, the biggest wins.

@tboerger
Copy link
Member

tboerger commented Nov 3, 2016

I don't have a strong opinion on that but generally I don;t think that this is a bad idea. For the people that don't like it it should also be an option to provide a flag to enable/disable it.

@xinity
Copy link
Contributor

xinity commented Nov 3, 2016

what would this progress bar helps with ?
don't get me wrong, it a good idea, i'm just wondering what i would help with in using gitea on a daily driver

@jhasse
Copy link

jhasse commented Nov 3, 2016

Is easy, you add only 2 files and nothing else

Of course you need to take the code inside pace.js and the css file into account. What if there's a security risk inside pace.js?

Btw: You forgot that Gogs can run on a subfolder of a domain, so these two lines already introduce a bug.

On my projects, don't have relevant increase load time

People on mobile connections? Also people with slower PCs? The js file needs to be parced. The progress bar needs to be drawn. It has a glow effect which uses alpha values if I'm not mistaken. This will cause more CPU / GPU load.

You might also try https://addons.mozilla.org/en-US/firefox/addon/progre. Works with Gogs/Gitea. And you can theme it.

@joubertredrat
Copy link
Contributor Author

joubertredrat commented Nov 3, 2016

Of course you need to take the code inside pace.js and the css file into account. What if there's a security risk inside pace.js?

Any library component for any language can have this risk

People on mobile connections? Also people with slower PCs? The js file needs to be parced. The progress bar needs to be drawn. It has a glow effect which uses alpha values if I'm not mistaken. This will cause more CPU / GPU load.

Yes, both on mobile using 3g and PC's with 1Gb RAM only, work normally.

How do we need the new relase of Gitea, we see other more important things, in future if is necessary, we reopen this.

@tboerger
Copy link
Member

tboerger commented Nov 3, 2016

Please keep enhancements open for not, it's tagged with a future milestone on purpose. If it's closed nobody will ever discuss about it or implement it.

@tboerger tboerger reopened this Nov 3, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Nov 4, 2016

@jhasse

You forgot that Gogs can run on a subfolder of a domain, so these two lines already introduce a bug.

That would've been caught in code-review, no need for nit-picking on pseudo-code in issues 😉

People on mobile connections? Also people with slower PCs? The js file needs to be parced. The progress bar needs to be drawn. It has a glow effect which uses alpha values if I'm not mistaken. This will cause more CPU / GPU load.

Could be disabled in user-settings. Also it works on Edge (GPRS++) without noticeably slowing it down 🙂

@jhasse
Copy link

jhasse commented Nov 4, 2016

That would've been caught in code-review, no need for nit-picking on pseudo-code in issues 😉

Just wanted to point out that there's more to it then initially thought.

Firefox for Android also has a progress bar btw.

@bkcsoft
Copy link
Member

bkcsoft commented Nov 7, 2016

Firefox for Android also has a progress bar btw.

Yes I know, this one hi-jacks it 😉

@jhasse
Copy link

jhasse commented Jan 6, 2017

Another browser with a built-in progress-bar: Vivaldi

@joubertredrat joubertredrat changed the title Loading progressbar on Gogs Loading progressbar on Gitea Jan 6, 2017
@joubertredrat
Copy link
Contributor Author

I will provide this as optional defined on configuration with default disabled, if you want to enable, set this on config

lunny referenced this issue in lunny/gitea Feb 7, 2019
According to git submodule documentation base path for relative submodule URL
is parent repository's root - not submodule "mount point".

So it's necessary to know "path" of parent repository to create correct submodule
URL.
lunny referenced this issue in lunny/gitea Feb 7, 2019
- Refactor some name
@stale
Copy link

stale bot commented Feb 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 17, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 18, 2019
@lafriks lafriks removed this from the 1.x.x milestone Dec 9, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

9 participants