Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JS dependencies #15033

Merged
merged 5 commits into from
Mar 22, 2021
Merged

Update JS dependencies #15033

merged 5 commits into from
Mar 22, 2021

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 18, 2021 •
edited
Loading

  • Update all JS dependencies
  • For octicons, rename trashcan to trash
  • For svgo, migrate to v2 api, regenerate files
  • For stylelint, update config, fix custom property duplicates
  • For monaco, drop legacy Edge support
  • For eslint, enable new rules, fix new issues
  • For less-loader, remove deprecated import syntax

@silverwind
Copy link
Member Author

silverwind commented Mar 19, 2021 •
edited
Loading

Will check later on the reason behind the SVG path changes. It looks like a svgo regression because the files are mostly larger than before.

Edit: svg/svgo#1436

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 19, 2021
@TrySound
Copy link

This is a fix for wider environments support. Not a regression.

@silverwind
Copy link
Member Author

Yeah, I just read into svg/svgo#1353 and it looks to be a compatibilty fix for SVG renderers that can not deal with the condensed arcto syntax. I think we can keep the change.

@silverwind silverwind mentioned this pull request Mar 20, 2021
Closed
@silverwind
Update JS dependencies
321ecae 
- Update all JS dependencies
- For octicons, rename trashcan to trash
- For svgo, migrate to v2 api, output seems to have slightly changed but icons look the same
- For stylelint, update config, fix custom property duplicates
- For monaco, drop legacy Edge support
- For eslint, enable new rules, fix new issues
- For less-loader, remove deprecated import syntax
@silverwind
update svgo usage in generate-images and rebuild logo.svg with it
267ffe1
@silverwind
update deps once more
9e8395c
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 21, 2021
@6543

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2021
@6543 6543 added this to the 1.15.0 milestone Mar 21, 2021
@silverwind
Copy link
Member Author

@6543 can't reproduce locally and google does not help on it either. Try a rm -rf node_modules?

@6543
Copy link
Member

6543 commented Mar 22, 2021

.

@6543 6543 merged commit 1a03fa7 into go-gitea:master Mar 22, 2021
@silverwind silverwind deleted the deps-22 branch March 22, 2021 08:06
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@silverwind @TrySound @6543 @lafriks @GiteaBot