Reduce memory usage in testgit #15306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/testing
skip-changelog
6543
approved these changes
Apr 6, 2021
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Apr 6, 2021
GiteaBot
added
lgtm/done
|
🚀 |
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Apr 6, 2021
* reduce memory use in rawtest * just use hashsum for diffs Signed-off-by: Andrew Thornton <art27@cantab.net>
lunny
pushed a commit
that referenced
this pull request
Apr 7, 2021
|
Did this change make the test flaky? I see a lot of
|
|
nope they've been there for a while. |
|
the problem appears to be in the results of the first diff which I think are incorrect somehow but yet do not return an error in the first place. |
|
the main thing is that we can now see it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several places where we are quite inefficient in test_git resulting in storing potentially large diffs and other things.
This PR stops this.