Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent race in TestChannelQueue_Batch #15703

Merged
merged 2 commits into from
May 3, 2021
Merged

Prevent race in TestChannelQueue_Batch #15703

merged 2 commits into from
May 3, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 2, 2021

There is a potential race in TestChannelQueue_Batch due to boost workers starting up

This PR simply removes the boosts from this test.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Prevent race in TestChannelQueue_Batch
59287ea 
There is a potential race in TestChannelQueue_Batch due to boost workers starting up

This PR simply removes the boosts from this test.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.15.0 milestone May 2, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #15703 (59287ea) into master (0590176) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15703      +/-   ##
==========================================
- Coverage   43.89%   43.88%   -0.01%     
==========================================
  Files         678      678              
  Lines       81866    81866              
==========================================
- Hits        35933    35927       -6     
- Misses      40084    40092       +8     
+ Partials     5849     5847       -2
Impacted Files Coverage Δ
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
routers/repo/view.go 40.66% <0.00%> (-0.59%) ⬇️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0590176...59287ea. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 2, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 2, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 3, 2021
@zeripath
Copy link
Contributor Author

zeripath commented May 3, 2021

make lgtm work

@zeripath zeripath merged commit d11b9fb into go-gitea:master May 3, 2021
@zeripath zeripath deleted the fix-race-in-TestChannelQueue_Batch branch May 3, 2021 16:17
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zeripath @codecov-commenter @KN4CK3R @6543 @GiteaBot