New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Potential color theme tweaks #15711
Comments
Whilst I agree that the red colour at present is a bit glaring I think your change is too dark. Have you tried a dark burgundy? |
Looking good. As for green, I suggest |
Both new colors fail the WCAG AA requirement, to pass that it'd have to be at least 4.5 ratio, for example |
I like it except the blueish header which seems a bit out of place but I see that color is also used on the frontpage, so it's a more involved change. Also, I would not use |
Looks great imho :) |
did you update the issue description screenshots with the current look @pat-s ? |
No, the current looks can be seen in the last comment which contains screenshots. Otherwise some comments would not make sense anymore which refer to the first proposals. |
will update it then :) |
@silverwind will need review at https://gitea.com/gitea/theme/pulls/95 :) |
PR is merged, but it does not seem to be live yet. |
@silverwind that's my bad, I hadn't updated CI secrets so it didn't publish. I've resolved that and next PR merged to this repo will update theme. |
Thanks! I was expecting the theme change to apply to all sites, albeit only the docs were updated. Might need to look again. |
@pat-s Docs are our only site that gets update frequently, although I had run the website CI too https://gitea.io/en-us/ I'll rebuild blogs as well. |
In my opinion the red-coloured code text is quite dominant and a bit too large.
I've taken a stab and aligned the text theming to GitHub ones.
Please 馃憤/馃憥 if you would like to see a change.
Changes
0.875em
to0.85em
border-radius: 6px;
0.25em 0.5em 0.25em;
to.2em .4em;
#24292e;
Current
New
Navbar background:
#f4f4f4
Link color
Another change, which could maybe be discussed separately, is the link color.
Here I also think that (#528321`) is actually more pleasant to the eyes than the current one.
Here's a preview of the proposed change:
pull: https://gitea.com/gitea/theme/pulls/95
The text was updated successfully, but these errors were encountered: