Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Potential color theme tweaks #15711

Closed
pat-s opened this issue May 3, 2021 · 15 comments
Closed

Docs: Potential color theme tweaks #15711

pat-s opened this issue May 3, 2021 · 15 comments
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/docs This PR mainly updates/creates documentation

Comments

@pat-s
Copy link
Member

pat-s commented May 3, 2021

In my opinion the red-coloured code text is quite dominant and a bit too large.

I've taken a stab and aligned the text theming to GitHub ones.

Please 馃憤/馃憥 if you would like to see a change.

Changes

  • Reduced font size from 0.875em to 0.85em
  • Added border-radius: 6px;
  • Changed padding from 0.25em 0.5em 0.25em; to .2em .4em;
  • Set font color to #24292e;

Current

image

New

Navbar background: #f4f4f4
image

Link color

Another change, which could maybe be discussed separately, is the link color.
Here I also think that (#528321`) is actually more pleasant to the eyes than the current one.

Here's a preview of the proposed change:

image


pull: https://gitea.com/gitea/theme/pulls/95

@pat-s pat-s added type/docs This PR mainly updates/creates documentation issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail labels May 3, 2021
@zeripath
Copy link
Contributor

zeripath commented May 3, 2021

Whilst I agree that the red colour at present is a bit glaring I think your change is too dark. Have you tried a dark burgundy?

@silverwind
Copy link
Member

Looking good. As for green, I suggest #609926 which is also used in the gitea logo.

@silverwind
Copy link
Member

silverwind commented May 3, 2021

#148f77 on #ffffff is 4.01:1 contrast ratio (current)
#609926 on #ffffff is 3.45:1 contrast ratio
#2ea44f on #ffffff is 3.21:1 contrast ratio

Both new colors fail the WCAG AA requirement, to pass that it'd have to be at least 4.5 ratio, for example #528321.

@pat-s
Copy link
Member Author

pat-s commented May 4, 2021

Ok, here's the next try

code {
    background-color: #ecf0f1;
    color: black;
    font-size: 0.85em;
    font-weight: normal;
    padding: .2em .4em;
    border-radius: 6px;
}

Also the body font is black here and the background #ecf0f1.

The green tone is #528321.

image

@silverwind
Copy link
Member

I like it except the blueish header which seems a bit out of place but I see that color is also used on the frontpage, so it's a more involved change. Also, I would not use black body text because it seems to harsh of a color against white, maybe #333 instead.

@pat-s
Copy link
Member Author

pat-s commented May 6, 2021

I also do not like the blue. I could think of a general recoloring using a greyish tone and #528321 (maybe the green tone of the gitea logo to stay consistent).

Main page

Navbar background: #f4f4f4

image

Docs

With #333 as the body font and #f8f8f8 as the navbar background.

image

@silverwind
Copy link
Member

Looks great imho :)

@6543
Copy link
Member

6543 commented Aug 1, 2021

did you update the issue description screenshots with the current look @pat-s ?

@pat-s
Copy link
Member Author

pat-s commented Aug 1, 2021

No, the current looks can be seen in the last comment which contains screenshots. Otherwise some comments would not make sense anymore which refer to the first proposals.

@6543
Copy link
Member

6543 commented Aug 1, 2021

will update it then :)

@6543
Copy link
Member

6543 commented Aug 1, 2021

@silverwind will need review at https://gitea.com/gitea/theme/pulls/95 :)

@silverwind
Copy link
Member

PR is merged, but it does not seem to be live yet.

@techknowlogick
Copy link
Member

@silverwind that's my bad, I hadn't updated CI secrets so it didn't publish. I've resolved that and next PR merged to this repo will update theme.

@pat-s
Copy link
Member Author

pat-s commented Aug 5, 2021

Thanks!

I was expecting the theme change to apply to all sites, albeit only the docs were updated. Might need to look again.

@techknowlogick
Copy link
Member

@pat-s Docs are our only site that gets update frequently, although I had run the website CI too https://gitea.io/en-us/ I'll rebuild blogs as well.

@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

No branches or pull requests

5 participants