Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix individual tests (addition to #15802) #15818

Merged
merged 12 commits into from May 12, 2021
Merged

Fix individual tests (addition to #15802) #15818

merged 12 commits into from May 12, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented May 10, 2021

I checked all unit tests if they can be run individual and some tests failed. This PR fixes these tests.

zeripath
zeripath reviewed May 10, 2021
View reviewed changes
models/avatar_test.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 10, 2021
zeripath
zeripath reviewed May 10, 2021
View reviewed changes
models/gpg_key_test.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 11, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2021
@techknowlogick
Copy link
Member

🚀

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2021 •
edited

Codecov Report

Merging #15818 (3e41111) into main (2dc3e4e) will increase coverage by 0.09%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15818      +/-   ##
==========================================
+ Coverage   43.92%   44.02%   +0.09%     
==========================================
  Files         681      681              
  Lines       82228    82231       +3     
==========================================
+ Hits        36120    36199      +79     
+ Misses      40205    40127      -78     
- Partials     5903     5905       +2
Impacted Files Coverage Δ
models/issue_xref.go 60.60% <0.00%> (-0.62%) ⬇️
modules/queue/manager.go 62.71% <50.00%> (+1.34%) ⬆️
modules/git/repo_commit.go 40.00% <0.00%> (-0.87%) ⬇️
models/error.go 39.84% <0.00%> (+0.31%) ⬆️
models/gpg_key.go 54.07% <0.00%> (+0.56%) ⬆️
models/notification.go 66.07% <0.00%> (+0.88%) ⬆️
services/pull/pull.go 43.83% <0.00%> (+0.91%) ⬆️
modules/notification/notification.go 87.60% <0.00%> (+2.47%) ⬆️
modules/notification/base/null.go 78.94% <0.00%> (+2.63%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96b1315...3e41111. Read the comment docs.

@techknowlogick techknowlogick merged commit 3d7d750 into go-gitea:main May 12, 2021
@techknowlogick techknowlogick added this to the 1.15.0 milestone May 12, 2021
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 12, 2021
@KN4CK3R KN4CK3R deleted the fix-individual-tests branch May 25, 2021 06:47
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@KN4CK3R @zeripath
@techknowlogick @AbdulrhmnGhanem
Fix individual tests (addition to go-gitea#15802) (go-gitea#15818)
14b3303 
* Decouple TestAction_GetRepoLink and TestSizedAvatarLink.

* Load database for TestCheckGPGUserEmail.

* Load database for TestMakeIDsFromAPIAssigneesToAdd.

* Load database for TestGetUserIDsByNames and TestGetMaileableUsersByIDs.

* Load database for TestUser_ToUser.

* Load database for TestRepository_EditWikiPage.

* Include AppSubURL in test.

* Prevent panic with empty slice.

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@KN4CK3R @techknowlogick @codecov-commenter @silverwind @zeripath @GiteaBot