Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goth user infer bug #15821

Merged
merged 1 commit into from
May 10, 2021
Merged

Fix goth user infer bug #15821

merged 1 commit into from
May 10, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented May 10, 2021 •
edited by zeripath

The goth user stored in session is the struct but not the pointer to it.

Bug introduced in #5123

@lunny lunny added the type/bug label May 10, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 10, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 10, 2021
@zeripath zeripath merged commit 3656a2a into go-gitea:main May 10, 2021
@6543 6543 added the issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself label May 10, 2021
@6543 6543 added this to the 1.15.0 milestone May 10, 2021
@lunny lunny deleted the lunny/fix_goth_user-infer branch May 11, 2021 06:49
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 11, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@lunny @AbdulrhmnGhanem
Fix goth user infer bug (go-gitea#15821)
245cfca
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
issue/regression Issue needs no code to be fixed, only a description on how to fix it yourself lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunny @KN4CK3R @zeripath @GiteaBot @6543