Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since Chi migration html rendering is essentially single threaded due to unrolled #15832

Closed
zeripath opened this issue May 11, 2021 · 2 comments · Fixed by #15845
Closed

Since Chi migration html rendering is essentially single threaded due to unrolled #15832

zeripath opened this issue May 11, 2021 · 2 comments · Fixed by #15845
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP
Milestone
1.14.3

Comments

@zeripath
Copy link
Contributor

There is a global lock in unrolled.render.HTML:

https://github.com/unrolled/render/blob/b7951a4bb643b89b5e45e179cee661139809c294/render.go#L392

Anything that holds up Rendering just blocks it for everyone and we essentially can only render one html template at a time.

Originally posted by @zeripath in #15826 (comment)
@zeripath zeripath added the issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP label May 11, 2021
@zeripath zeripath added this to the 1.14.3 milestone May 11, 2021
@zeripath
Copy link
Contributor Author

See: unrolled/render#90

This was referenced May 12, 2021
Merged
Merged
@zeripath
Copy link
Contributor Author

Fixed by #15845

@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP
Projects
None yet
Milestone
1.14.3
Development

Successfully merging a pull request may close this issue.

Upgrade unrolled/render to v1.1.1 lunny/gitea
1 participant
@zeripath