Only offer hostcertificates if they exist #15849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common bug report is the otherwise harmless sshd logging: ``` Could not load host certificate "/data/ssh/ssh_host_ed25519_cert": No such file or directory ``` This PR simply checks if these files exist before creation of sshd_config and if they do not exist, doesn't add a reference to them. Fix go-gitea#14110 amongst others. Signed-off-by: Andrew Thornton <art27@cantab.net>
silverwind
reviewed
May 12, 2021
GiteaBot
added
the
lgtm/need 2
Co-authored-by: silverwind <me@silverwind.io>
lafriks
approved these changes
May 13, 2021
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
May 13, 2021
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #15849 +/- ##
=======================================
Coverage 44.01% 44.01%
=======================================
Files 681 681
Lines 82243 82243
=======================================
Hits 36196 36196
- Misses 40139 40140 +1
+ Partials 5908 5907 -1
Continue to review full report at Codecov.
|
|
please send backport |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
May 13, 2021
Backport go-gitea#15849 A common bug report is the otherwise harmless sshd logging: ``` Could not load host certificate "/data/ssh/ssh_host_ed25519_cert": No such file or directory ``` This PR simply checks if these files exist before creation of sshd_config and if they do not exist, doesn't add a reference to them. Fix go-gitea#14110 amongst others. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lauris BH <lauris@nix.lv>
techknowlogick
pushed a commit
that referenced
this pull request
May 13, 2021
Backport #15849 A common bug report is the otherwise harmless sshd logging: ``` Could not load host certificate "/data/ssh/ssh_host_ed25519_cert": No such file or directory ``` This PR simply checks if these files exist before creation of sshd_config and if they do not exist, doesn't add a reference to them. Fix #14110 amongst others. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lauris BH <lauris@nix.lv> Co-authored-by: 6543 <6543@obermui.de>
|
Funny, I was just dealing with this in our own fork, but commented it out, and then saw this conflicted with my changes. Thanks for putting those if-thens in there @zeripath ! |
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 10, 2021
A common bug report is the otherwise harmless sshd logging: ``` Could not load host certificate "/data/ssh/ssh_host_ed25519_cert": No such file or directory ``` This PR simply checks if these files exist before creation of sshd_config and if they do not exist, doesn't add a reference to them. Fix go-gitea#14110 amongst others. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: Lauris BH <lauris@nix.lv>
delvh
added
topic/distribution
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common bug report is the otherwise harmless sshd logging:
This PR simply checks if these files exist before creation of sshd_config and if
they do not exist, doesn't add a reference to them.
Close #14110
Close #13724
Signed-off-by: Andrew Thornton art27@cantab.net