Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customization files should not require /assets path segment #15906

Closed
silverwind opened this issue May 17, 2021 · 3 comments
Closed

Customization files should not require /assets path segment #15906

silverwind opened this issue May 17, 2021 · 3 comments
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Milestone
1.15.0

Comments

@silverwind
Copy link
Member

silverwind commented May 17, 2021 •
edited
Loading

Since #15219, previous customization files like $GITEA_CUSTOM/public/img/logo.svg are not loaded any more and require $GITEA_CUSTOM/public/assets/img/logo.svg to be loaded again, we should fix this because the assets segment should only be relevant on HTTP, not in the file system.
@silverwind silverwind added this to the 1.15.0 milestone May 18, 2021
@silverwind
Copy link
Member Author

@a1012112796 fyi.

@lunny
Copy link
Member

lunny commented Jun 1, 2021

I think this has been resolved by #15961 .

@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 1, 2021
@silverwind
Copy link
Member Author

Yeah, just rebuilt with that, seems to have been resolved.

@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.15.0
Development

No branches or pull requests
2 participants
@lunny @silverwind