Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow more than one comment per line #15916

Open
delvh opened this issue May 18, 2021 · 0 comments
Open

[Feature] Allow more than one comment per line #15916

delvh opened this issue May 18, 2021 · 0 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@delvh
Copy link
Member

delvh commented May 18, 2021

  • Gitea version (or commit ref): 1.14.2 and most current ones
  • Can you reproduce the bug at https://try.gitea.io: Most likely, but I cannot be sure as it would be better if it could be tested against another persons comment

Description

Currently when adding a comment to a line in a code review, no one else can add a comment to that line, unless he adds an answer to the already existing comment.
While in most cases that suffices and is wanted, in the case where there are two separate things that should be mentioned regarding this line it will fail. Especially bad because if the answer workaround gets taken, resolving that thread automatically resolves the other issue as well, even though that point may not be resolved yet.

As this is indeed a rather rare case, I'd suggest using a linked comment (comment that refers to its comment below or nil if none present) here instead of a list of comments.

Screenshots

Screenshot_20210518_142504
This screenshot shows that I cannot add a comment on that line anymore while one line below (see screenshot below), I can still add a comment:
Screenshot_20210518_142529

@noerw noerw added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants