Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In pull request, can't add review with thumbup emoji #15922

Closed
4 tasks
mctaguma opened this issue May 19, 2021 · 2 comments
Closed
4 tasks

In pull request, can't add review with thumbup emoji #15922

mctaguma opened this issue May 19, 2021 · 2 comments
Labels
issue/duplicate The issue has already been reported. issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail

Comments

@mctaguma
Copy link

mctaguma commented May 19, 2021

  • Gitea version (or commit ref): 1.14.2
  • Git version: 1.8.3.1
  • Operating system: CentOS Linux release 7.9.2009 (Core)

I'm using the gitea binary from the 1.14.2 release (https://github.com/go-gitea/gitea/releases/tag/v1.14.2), and I'm running this with systemd.

  • Database (use [x]):
    • PostgreSQL
    • [ x ] MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • [ x ] No
  • Log gist:

2021/05/19 15:26:30 .../repo/pull_review.go:219:SubmitReview() [E] SubmitReview: Error 1366: Incorrect string value: '\xF0\x9F\x91\x8D ' for column gitea.review.content at row 1

Description

When I do a review within a pull request, and use the thumbup (+1) emoji in the review comment textarea, I get a 500 error with the below logged error:

2021/05/19 15:26:30 .../repo/pull_review.go:219:SubmitReview() [E] SubmitReview: Error 1366: Incorrect string value: '\xF0\x9F\x91\x8D ' for column gitea.review.content at row 1

Screenshots

image

@silverwind
Copy link
Member

Are you using MySQL? If so you probably need to convert the tables to utf8mb4, gitea convert can help with that but take a backup before doing it.

@noerw noerw added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label May 20, 2021
@zeripath
Copy link
Contributor

This is clearly YET ANOTHER mysql utf8 Vs utf8mb4 issue.

Please read the extensive number of issues relating to this and run: gitea convert and change your app.ini to use charset=utf8mb4.

@zeripath zeripath added the issue/duplicate The issue has already been reported. label Jun 23, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/duplicate The issue has already been reported. issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail
Projects
None yet
Development

No branches or pull requests

5 participants