Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just add some unit tests #16291

Merged
merged 6 commits into from
Jun 29, 2021
Merged

just add some unit tests #16291

merged 6 commits into from
Jun 29, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 29, 2021

as title

wip since I will add a few more to not make to noicy pulls

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021 •
edited

Codecov Report

Merging #16291 (778886c) into main (6554835) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16291      +/-   ##
==========================================
+ Coverage   45.42%   45.45%   +0.03%     
==========================================
  Files         709      709              
  Lines       83500    83502       +2     
==========================================
+ Hits        37929    37956      +27     
+ Misses      39490    39462      -28     
- Partials     6081     6084       +3
Impacted Files Coverage Δ
models/convert.go 0.00% <0.00%> (ø)
modules/indexer/stats/db.go 42.85% <0.00%> (-7.15%) ⬇️
models/unit.go 41.09% <0.00%> (-2.74%) ⬇️
modules/queue/workerpool.go 53.05% <0.00%> (-1.53%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
routers/install/install.go 0.66% <0.00%> (+0.66%) ⬆️
modules/log/event.go 61.79% <0.00%> (+1.88%) ⬆️
routers/utils/utils.go 100.00% <0.00%> (+18.18%) ⬆️
routers/install/routes.go 45.76% <0.00%> (+45.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6554835...778886c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 29, 2021
@6543 6543 marked this pull request as ready for review June 29, 2021 19:22
@6543 6543 added this to the 1.15.0 milestone Jun 29, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 29, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 29, 2021
@6543
Copy link
Member Author

6543 commented Jun 29, 2021

🚀

@zeripath zeripath merged commit dea7a5c into go-gitea:main Jun 29, 2021
@6543 6543 deleted the unit-tests branch June 29, 2021 21:17
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@6543 @AbdulrhmnGhanem
just add some unit tests (go-gitea#16291)
0e31fce 
* code.gitea.io/gitea/routers/utils coverage: 100.0%

* code.gitea.io/gitea/routers/install 0% -> 5.0%

* ConvertUtf8ToUtf8mb4: make sure DBType is mysql
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@6543 @codecov-commenter @techknowlogick @zeripath @GiteaBot