Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL, Postgres integration tests in drone #1638

Merged
merged 4 commits into from Apr 30, 2017
Merged

MySQL, Postgres integration tests in drone #1638

merged 4 commits into from Apr 30, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Apr 28, 2017 •
edited

Run make test-mysql and make test-pgsql in drone.

@ethantkoenig ethantkoenig changed the title Enable mysql testing for drone MySQL, Postgres integration tests in drone Apr 28, 2017
@lunny lunny added this to the 1.2.0 milestone Apr 29, 2017
@lunny
Copy link
Member

lunny commented Apr 29, 2017

@ethantkoenig I resigned drone.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 29, 2017
@ethantkoenig
Copy link
Member Author

@lunny There was a mistake in .drone.yml, so I will need a new signature

@lunny
Copy link
Member

lunny commented Apr 30, 2017

@ethantkoenig rebased and resigned

@lunny
Copy link
Member

lunny commented Apr 30, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 30, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2017
@appleboy
Copy link
Member

@lunny sig file conflict.

@appleboy
Copy link
Member

make L-G-T-M work

@appleboy appleboy merged commit 66c803f into go-gitea:master Apr 30, 2017
@ethantkoenig ethantkoenig deleted the etk/integration branch April 30, 2017 17:27
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ethantkoenig @lunny @appleboy @tboerger