Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make openid support default false for compitable with v1.1 #1650

Merged
merged 1 commit into from May 1, 2017
Merged

Make openid support default false for compitable with v1.1 #1650

merged 1 commit into from May 1, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented May 1, 2017

And also disable OpenID register if OpenID sign in disabled.

@lunny lunny added the type/enhancement An improvement of existing functionality label May 1, 2017
@lunny lunny added this to the 1.2.0 milestone May 1, 2017
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2017
@appleboy
Copy link
Member

appleboy commented May 1, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 1, 2017
@sapk
Copy link
Member

sapk commented May 1, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2017
@lunny lunny merged commit 3ebbdfa into go-gitea:master May 1, 2017
@lunny lunny deleted the lunny/default_disable_openid branch May 1, 2017 16:27
@strk
Copy link
Member

strk commented May 1, 2017 via email

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lunny @appleboy @sapk @strk @tboerger