Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xorm to latest version #1651

Merged
merged 2 commits into from
May 2, 2017
Merged

Update xorm to latest version #1651

merged 2 commits into from
May 2, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 1, 2017

Update xorm to latest version to remove debug output from console that have been fixed upstream

@lunny lunny added this to the 1.2.0 milestone May 1, 2017
@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 1, 2017
@lunny
Copy link
Member

lunny commented May 1, 2017

@lafriks Thanks. But maybe you have to update github.com/go-xorm/core and github.com/go-xorm/builder too since they are the dependencies of xorm.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2017
@lafriks
Copy link
Member Author

lafriks commented May 1, 2017

xorm/core has not changed but updated also builder

@lunny
Copy link
Member

lunny commented May 1, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 1, 2017
@sapk
Copy link
Member

sapk commented May 1, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 1, 2017
@lunny lunny merged commit 3792867 into go-gitea:master May 2, 2017
@lafriks lafriks deleted the update_xorm_dependency branch May 7, 2017 16:43
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lafriks @lunny @sapk @tboerger