Exposes in API the Repo entity's Size and IsBare property #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
|
LG-TM depends on go-gitea/go-sdk#56 |
tboerger
added
the
lgtm/need 2
lafriks
requested changes
May 4, 2017
models/repo.go
Outdated
| @@ -286,6 +286,7 @@ func (repo *Repository) APIFormat(mode AccessMode) *api.Repository { | |||
| Description: repo.Description, | |||
| Private: repo.IsPrivate, | |||
| Empty: repo.IsBare, | |||
| Size: repo.Size, | |||
There was a problem hiding this comment.
it should return Size in kilobytes not bytes like it is in GitHub API
lunny
added
modifies/api
guyzmo
force-pushed
the
feature/api_exposes_extra_properties
branch
from
27a70ff
to
6f6167b
Compare
guyzmo
added a commit
to guyzmo/git-repo
that referenced
this pull request
May 4, 2017
for Gogs/Gitea, API is not yet out, cf following PRs: cf unfoldingWord-dev/python-gitea-client#9 cf go-gitea/go-sdk#56 cf go-gitea/gitea#1668 cf gogs/gogs#4484 cf gogs/go-gogs-client#64 fixes #129
|
@guyzmo You need to update the vendoring :) |
Signed-off-by: Guyzmo <guyzmo+github+pub@m0g.net>
guyzmo
force-pushed
the
feature/api_exposes_extra_properties
branch
from
6f6167b
to
69f0ad4
Compare
|
done |
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
7 tasks
sapk
added a commit
to sapk-fork/gitea
that referenced
this pull request
May 14, 2017
changes introduced to repo format by : go-gitea#1687 go-gitea/go-sdk#58 go-gitea#1668 go-gitea/go-sdk#56
Merged
appleboy
pushed a commit
that referenced
this pull request
May 14, 2017
changes introduced to repo format by : #1687 go-gitea/go-sdk#58 #1668 go-gitea/go-sdk#56
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exposes IsBare as Empty
exposes Size