Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display images inline in issues/pull requests #17419

Closed
davidak opened this issue Oct 24, 2021 · 6 comments
Closed

Display images inline in issues/pull requests #17419

davidak opened this issue Oct 24, 2021 · 6 comments
Labels
topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance

Comments

@davidak
Copy link

davidak commented Oct 24, 2021

Feature Description

instead of the current image preview section

that way i can have the images in the context of my text that describe the issue seen in the image

the usage of images in issues and pull request does not really work currently, since the reader does not know which image you are referring to

example:

i like how this looks:

Screenshot from 2021-10-24 17-07-03

this is not so good:

Screenshot from 2021-10-24 17-07-37

this is how it looks on gitea:

https://try.gitea.io/davidak/testing/issues/1

i selected both images to upload and they even have the wrong order, so the first line of text refers to the second image

another example:

same issue on gitea and github. in the latter, the images is bigger and is more helpful

https://git.gieszer.link/unfa/liblast/issues/92
godotengine/godot#53530

this is the biggest issue i have with gitea and it annoys me every time i add images to issues

please do it like github and gitlab does it!

(i thought there was an issue for this, but i was not able to find it)

Screenshots

No response

@wxiaoguang
Copy link
Contributor

I think it's a UX problem.

If you paste the image from clipboard into the text area directly, it will be inserted automatically.

But if you just drop files into the upload area or upload files manually, the file isn't inserted into the text area.

@wxiaoguang wxiaoguang added topic/ui-interaction Change the process how users use Gitea instead of the visual appearance topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile topic/ui Change the appearance of the Gitea UI and removed topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Oct 24, 2021
@davidak
Copy link
Author

davidak commented Oct 24, 2021

Even when inserted from clipboard, there is a list of attached files. I don't that that is very useful and just clutters the UI.

@wxiaoguang
Copy link
Contributor

Agree, indeed, it is a UI/UX problem.

@lunny
Copy link
Member

lunny commented Oct 25, 2021

It's better that the attached files could be collapsed.

@qwerty287
Copy link
Contributor

Duplicate of #12795?

@davidak
Copy link
Author

davidak commented Oct 25, 2021

@lunny there is no need for an attached files list. it just clutters the UI. you wouldn't add it here. it does not fit

example of files:

avatar

coca_source.zip

@qwerty287 yes, i actually commented there. the title is a bit hard to find

@davidak davidak closed this as completed Oct 25, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance
Projects
None yet
Development

No branches or pull requests

4 participants