Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label template dropdown list directories #17490

Closed
volker-raschek opened this issue Oct 30, 2021 · 4 comments
Closed

label template dropdown list directories #17490

volker-raschek opened this issue Oct 30, 2021 · 4 comments

Comments

@volker-raschek
Copy link

Gitea Version

v1.15.3

Git Version

No response

Operating System

No response

How are you running Gitea?

Via kubernetes v1.22.2

Database

PostgreSQL

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

Hi, I added a feature request for the helm chart of gitea to support the creation of custom gitignores, repository labels, licenses and README files - official documentation. The files are added via a config map into the file system. Kubernetes creates additionally a directory named data with a timestamp. This directory is listed in the drop down menue of all values which are configurable.

Here is a screenshot:

Bildschirmfoto vom 2021-10-30 13-47-35

Please, can you fix the drop down menues, that the directories created via kubernetes will not be listed?

Screenshots

No response

@justusbunsi
Copy link
Member

Interesting that the directories used by Kubernetes doesn't provide labels although the ..data directory contains the actual folder listed as myLabels. Maybe it could be a first approach to filter out empty lists and use the deepest directory level and dedup lists. 🤔

@wxiaoguang
Copy link
Contributor

This issue should have been fixed.

@justusbunsi
Copy link
Member

In current release or dev/next tag?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Apr 20, 2023

1.19: fatal error: Unable to read file "/Users/developer/work/gitea/custom/options/label/MyDir". Error: read /Users/developer/work/gitea/custom/options/label/MyDir: is a directory

Then user could remove the directory manually

1.20: No fatal error, the directory is not listed (only files are listed), because the new "AssetFS" works better for local assets.

@lunny lunny closed this as completed Apr 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants