-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for backend development #17512
Conversation
Some more things:
|
|
I have a problem with singular in my package PR because |
Both are fine to me. For singular, it's more likely to conflict with normal variable names. For example, usually we have alot of code like this Since we can make an agreement, these points can be written into document, including how to name variables to prevent conflict, then we have a more clear review guideline. |
88ab029
to
8855686
Compare
I'm ok for some special situations. |
LGTM, More points:
|
About the tracing, could you help to open an issue to describe the idea? And also if there is an example PR, that's great. |
458dad3
to
ac89a74
Compare
* Add documentation for backend development * Update backend guidline * More sections * Add modules/setting and modules/git * Uniform gitea as Gitea * some improvements * some improvements
To clarify how the Gitea backend code organized, I propose the document to help contributors on writing backend codes.