Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move user functions into user.go #17659

Merged
merged 4 commits into from
Nov 18, 2021
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 16, 2021

As title.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 16, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 16, 2021
@zeripath
Copy link
Contributor

Hmm... Why not make this notice_model instead?

@lunny
Copy link
Member Author

lunny commented Nov 17, 2021

Hmm... Why not make this notice_model instead?

Then we just have two files in this sub model? It's too small so that we may have too many sub packages in models. I name it admin_model so that more models files could be moved in future.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 17, 2021
@lunny lunny force-pushed the lunny/model_admin_part1 branch 4 times, most recently from 54d03b4 to de60dcc Compare November 17, 2021 10:05
@codecov-commenter
Copy link

Codecov Report

Merging #17659 (03f1311) into main (8fdc524) will increase coverage by 0.11%.
The diff coverage is 53.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17659      +/-   ##
==========================================
+ Coverage   45.35%   45.47%   +0.11%     
==========================================
  Files         799      800       +1     
  Lines       89062    89228     +166     
==========================================
+ Hits        40393    40574     +181     
+ Misses      42163    42121      -42     
- Partials     6506     6533      +27     
Impacted Files Coverage Δ
cmd/admin.go 0.00% <0.00%> (ø)
cmd/doctor.go 0.00% <ø> (ø)
cmd/hook.go 7.79% <ø> (+0.01%) ⬆️
cmd/mailer.go 0.00% <ø> (ø)
cmd/web.go 0.00% <ø> (ø)
models/consistency.go 8.84% <0.00%> (ø)
models/db/engine.go 32.00% <ø> (ø)
models/error.go 38.81% <ø> (+0.33%) ⬆️
models/issue_list.go 71.80% <ø> (ø)
models/repo_indexer.go 53.22% <ø> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6874fe9...03f1311. Read the comment docs.

@lunny lunny merged commit 3c3855a into go-gitea:main Nov 18, 2021
@lunny lunny deleted the lunny/model_admin_part1 branch November 18, 2021 05:58
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* Move user functions into user.go

* Fix test
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants