Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify parameter types #18006

Merged
merged 4 commits into from
Dec 20, 2021
Merged

Simplify parameter types #18006

merged 4 commits into from
Dec 20, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Dec 16, 2021 •
edited by zeripath
Loading

Remove repeated type declarations in function definitions.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Dec 17, 2021
lunny
lunny approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@lunny lunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we should have a lint for that.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 17, 2021
wxiaoguang
wxiaoguang approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems nice to have, but not a must.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2021
@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 20, 2021
@zeripath zeripath merged commit ff2fd08 into go-gitea:main Dec 20, 2021
@zeripath zeripath changed the title Refactor: simplify paramater types Simplify parameter types Dec 20, 2021
@Gusted Gusted deleted the simplify-type branch January 2, 2022 22:49
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@Gusted
Simplify parameter types (go-gitea#18006)
39b7aab 
Remove repeated type declarations in function definitions.
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Gusted @zeripath @lunny @wxiaoguang @GiteaBot