Role issue

[Gusted]

• Avoid re-assignments xxx = xxx.WithRole(xxx).
• Enable modifies-value-receiver rule(this was the only error)

[wxiaoguang]

In Golang, c2 = WithContext(c1) means c1 is unchanged and returns a new c2.

So WithRole seems not following the naming style here. Perhaps we can think a new name for it.

[lunny]

• Avoid re-assignments xxx = xxx.WithRole(xxx).
• Enable modifies-value-receiver rule(this was the only error)

I against this. Int is efficient enough. We don't need the pointer. No benefit from the refactor.

[wxiaoguang]

Or could we just disable the lint for RoleDescriptor? The old code seems fine. :)

[Gusted]

The old code seems fine. :)

The old code is fine indeed, after applying the suggestion from lunny(which is the actual correct fix for the linter).

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (main@4da2eab). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main   #18093   +/-   ##
=======================================
  Coverage        ?   44.87%           
=======================================
  Files           ?      824           
  Lines           ?    91581           
  Branches        ?        0           
=======================================
  Hits            ?    41097           
  Misses          ?    43891           
  Partials        ?     6593           

Impacted Files	Coverage Δ
models/issue_comment.go	52.40% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4da2eab...f5032cd. Read the comment docs.