tests: s/GITEA_UNIT_TESTS_VERBOSE/GITEA_UNIT_TESTS_LOG_SQL/ #18142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singuliere
force-pushed
the
wip-document-test-sql
branch
from
2aa1bbf
to
24de44e
Compare
zeripath
approved these changes
Dec 31, 2021
GiteaBot
added
the
lgtm/need 1
|
After renaming, I think we can safely drop the |
|
Agreed either way |
The GITEA_UNIT_TESTS_VERBOSE variable is an undocumented variable introduced in 2017 (see 1028ef2) whose sole purpose has been to log SQL statements when running unit tests. It is renamed for clarity. The documentation is updated to reflect this change. Signed-off-by: singuliere <singuliere@autistici.org>
singuliere
force-pushed
the
wip-document-test-sql
branch
from
24de44e
to
2bba361
Compare
I dropped the backward compatibility change as requested. |
6543
approved these changes
Dec 31, 2021
GiteaBot
added
lgtm/done
6543
reviewed
Dec 31, 2021
Codecov Report
@@ Coverage Diff @@
## main #18142 +/- ##
=======================================
Coverage ? 44.91%
=======================================
Files ? 825
Lines ? 91576
Branches ? 0
=======================================
Hits ? 41135
Misses ? 43862
Partials ? 6579
Continue to review full report at Codecov.
|
wxiaoguang
approved these changes
Jan 1, 2022
wxiaoguang
added
type/testing
skip-changelog
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 1, 2022
* giteaoffical/main: tests: s/GITEA_UNIT_TESTS_VERBOSE/GITEA_UNIT_TESTS_LOG_SQL/ (go-gitea#18142) services/repository: fix ListUnadoptedRepositories incorrect total count (go-gitea#17865) Improve document for developers: Windows CGO, unit test option (go-gitea#18140) Reset the conflicted files list in testpatch (go-gitea#18139) Use correct translation key (go-gitea#18135)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…#18142) The GITEA_UNIT_TESTS_VERBOSE variable is an undocumented variable introduced in 2017 (see 1028ef2) whose sole purpose has been to log SQL statements when running unit tests. It is renamed for clarity and a warning is displayed for backward compatibility for people and scripts that know about it. The documentation is updated to reflect this change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GITEA_UNIT_TESTS_VERBOSE variable is an undocumented variable
introduced in 2017 (see 1028ef2)
whose sole purpose has been to log SQL statements when running unit
tests.
It is renamed for clarity and a warning is displayed for backward
compatibility for people and scripts that know about it.
The documentation is updated to reflect this change.