Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring nits #18188

Merged
merged 4 commits into from
Jan 5, 2022
Merged

refactoring nits #18188

merged 4 commits into from
Jan 5, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 5, 2022

refactoring nits from #18184

@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 5, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 5, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 5, 2022
@6543
Copy link
Member Author

6543 commented Jan 5, 2022

.

@6543 6543 merged commit 0572c78 into go-gitea:main Jan 5, 2022
@6543 6543 deleted the nits branch January 5, 2022 06:27
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 6, 2022
* 'main' of https://github.com/go-gitea/gitea:
  Enable partial clone by default (go-gitea#18195)
  Add option to convert CRLF to LF line endings for sendmail (go-gitea#18075)
  Add replay of webhooks. (go-gitea#18191)
  Load EasyMDE/CodeMirror dynamically, remove RequireEasyMDE (go-gitea#18069)
  refactoring nits (go-gitea#18188)
  slight optimization for default avatar (go-gitea#18187)
  code.gitea.io/sdk/gitea v0.14.0 -> v0.15.1 (go-gitea#18186)
  Team permission allow different unit has different permission (go-gitea#17811)
  Integration test for migration (go-gitea#18124)
  Update `TODOs` badge to reflect new default branch (go-gitea#18182)
  Increase Salt randomness  (go-gitea#18179)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* no octal for time values

* rm artifact from refactoring

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants