Fix CSS specificity issue with easymde's css #18201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR go-gitea#18069 introduced a regression in certain overwritten editor styles because the dynamic loading of easymde.min.css causes its's style to apply after our supposed override styles. Solve this by bundling the styles into index.css. We should later aim to completely replace easymde.min.css completely with our own styles so there are no more conflicts.
Gusted
approved these changes
Jan 7, 2022
GiteaBot
added
the
lgtm/need 1
lunny
approved these changes
Jan 7, 2022
GiteaBot
added
lgtm/done
wxiaoguang
approved these changes
Jan 7, 2022
wxiaoguang
added
the
skip-changelog
zjjhot
pushed a commit
to zjjhot/gitea
that referenced
this pull request
Jan 7, 2022
* 'main' of https://github.com/go-gitea/gitea: Fix CSS specificity issue with easymde's css (go-gitea#18201)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Fix CSS specificity issue with easymde's css PR go-gitea#18069 introduced a regression in certain overwritten editor styles because the dynamic loading of easymde.min.css causes its's style to apply after our supposed override styles. Solve this by bundling the styles into index.css. We should later aim to completely replace easymde.min.css completely with our own styles so there are no more conflicts. * Update web_src/js/features/comp/EasyMDE.js Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #18069 introduced a regression in certain overwritten editor styles because the dynamic loading of easymde.min.css causes its's style to apply after our supposed override styles, so they won in terms of CSS specificity over our styles.
Solve this by bundling the styles from easymde.min.css into index.css. We should later aim to completely replace easymde.min.css with our own styles so there are no more conflicts.
Before:
After:
