Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect OAuth message #18332

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 19, 2022

As the title, close #18327

Before

image

After

(ignore the empty application name Authorize "" in the screenshot, that part is filled by a mock 😊)

image

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 19, 2022
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jan 19, 2022
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Jan 19, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #18332 (71187a5) into main (212e81f) will increase coverage by 0.01%.
The diff coverage is 63.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18332      +/-   ##
==========================================
+ Coverage   45.74%   45.76%   +0.01%     
==========================================
  Files         831      831              
  Lines       92178    92222      +44     
==========================================
+ Hits        42171    42206      +35     
- Misses      43249    43258       +9     
  Partials     6758     6758              
Impacted Files Coverage Δ
models/issue_lock.go 0.00% <0.00%> (ø)
modules/structs/repo.go 80.76% <ø> (ø)
routers/api/v1/repo/issue_comment.go 37.82% <0.00%> (ø)
services/issue/status.go 41.66% <0.00%> (ø)
services/migrations/gitea_uploader.go 27.04% <0.00%> (-0.09%) ⬇️
services/pull/merge.go 48.21% <0.00%> (-0.12%) ⬇️
services/repository/files/upload.go 0.00% <0.00%> (ø)
routers/web/repo/issue.go 38.91% <16.66%> (+0.02%) ⬆️
models/issue.go 58.84% <30.76%> (-0.35%) ⬇️
models/migrate.go 42.96% <40.00%> (-9.57%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 531b6d6...71187a5. Read the comment docs.

@zeripath zeripath merged commit 6fba174 into go-gitea:main Jan 19, 2022
@wxiaoguang wxiaoguang deleted the fix-incorrect-oauth-messasge branch January 20, 2022 03:38
zjjhot pushed a commit to zjjhot/gitea that referenced this pull request Jan 20, 2022
* 'main' of https://github.com/go-gitea/gitea:
  Change initial TrustModel to committer (go-gitea#18335)
  refactor httplib (go-gitea#18338)
  Propagate context and ensure git commands run in request context (go-gitea#17868)
  Upgrade Alpine from 3.13 to 3.15 (go-gitea#18050)
  [skip ci] Updated translations via Crowdin
  Stop trimming preceding and suffixing spaces from editor filenames (go-gitea#18334)
  [skip ci] Updated translations via Crowdin
  Left-Align text in Unicode warning boxes (go-gitea#18331)
  Only warn on bidi but still escape non-bidi (go-gitea#18333)
  Fix incorrect OAuth message (go-gitea#18332)
  [skip ci] Updated translations via Crowdin
  Changelog for 1.16.0-rc1 (go-gitea#18309)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The messages for OAuth Authorize page are escaped incorrectly.
7 participants