Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit jQuery import, remove unused eslint globals #18435

Merged
merged 3 commits into from
Jan 28, 2022
Merged

Use explicit jQuery import, remove unused eslint globals #18435

merged 3 commits into from
Jan 28, 2022

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jan 27, 2022 •
edited

  • Don't rely on globals (window.$) for jQuery import
  • Remove eslint globals no longer in use

Gave it a cursory testing, everything still seems to work.

@silverwind
Use explicit jQuery import, remove unused eslint globals
d73ad05 
- Don't rely on globals (window.$) for jQuery import
- Remove eslint globals no longer in use
@silverwind silverwind added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 27, 2022
@silverwind silverwind added this to the 1.17.0 milestone Jan 27, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 28, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2022
@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath merged commit 19b017f into go-gitea:main Jan 28, 2022
@silverwind silverwind deleted the rmglobals branch January 29, 2022 00:04
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@silverwind
Use explicit jQuery import, remove unused eslint globals (go-gitea#18435
0efd24f 
)

- Don't rely on globals (window.$) for jQuery import
- Remove eslint globals no longer in use
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@silverwind @zeripath @lunny @wxiaoguang @GiteaBot @lafriks